From: Eric Engestrom <eric.engestrom@intel.com>
Date: Fri, 22 Mar 2019 16:54:57 +0000 (+0000)
Subject: util/process: document memory leak
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d1dd3cbcc766a70ec3b193201299792566c6b69a;p=mesa.git

util/process: document memory leak

We consider it acceptable, but let's still document it in case people
notice it and are not sure why it's there.

Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
---

diff --git a/src/util/u_process.c b/src/util/u_process.c
index a1667e78074..94c975df396 100644
--- a/src/util/u_process.c
+++ b/src/util/u_process.c
@@ -52,6 +52,10 @@ __getProgramName()
       static char *path;
 
       if (!path)
+         /* Note: realpath() allocates memory that we will keep around for
+          * the lifetime of the app, and then leak as the app closes.
+          * FIXME: we should find a way to clean this properly
+          */
          path = realpath("/proc/self/exe", NULL);
 
       if (path && strncmp(path, program_invocation_name, strlen(path)) == 0) {