From: Jonathan Wakely Date: Tue, 14 Nov 2017 18:00:53 +0000 (+0000) Subject: Fix typo in std::wbuffer_convert X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d2e9196e5f8849bac2d4fa7fa5599eb2338c76bd;p=gcc.git Fix typo in std::wbuffer_convert * include/bits/locale_conv.h (wbuffer_convert::_M_conv_get): Fix typo. * testsuite/22_locale/conversions/buffer/3.cc: New test. From-SVN: r254735 --- diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index db6712f3af7..6a7e22b0b1b 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,3 +1,8 @@ +2017-11-14 Jonathan Wakely + + * include/bits/locale_conv.h (wbuffer_convert::_M_conv_get): Fix typo. + * testsuite/22_locale/conversions/buffer/3.cc: New test. + 2017-11-10 Jonathan Wakely * testsuite/util/testsuite_tr1.h (ThrowMoveConsClass): Use noexcept. diff --git a/libstdc++-v3/include/bits/locale_conv.h b/libstdc++-v3/include/bits/locale_conv.h index 47c8dee53cb..b8f77dcaca9 100644 --- a/libstdc++-v3/include/bits/locale_conv.h +++ b/libstdc++-v3/include/bits/locale_conv.h @@ -431,7 +431,7 @@ _GLIBCXX_END_NAMESPACE_CXX11 streamsize __nbytes = sizeof(_M_get_buf) - _M_unconv; __nbytes = std::min(__nbytes, _M_buf->in_avail()); if (__nbytes < 1) - __nbytes == 1; + __nbytes = 1; __nbytes = _M_buf->sgetn(_M_get_buf + _M_unconv, __nbytes); if (__nbytes < 1) return false; diff --git a/libstdc++-v3/testsuite/22_locale/conversions/buffer/3.cc b/libstdc++-v3/testsuite/22_locale/conversions/buffer/3.cc new file mode 100644 index 00000000000..99a679dc124 --- /dev/null +++ b/libstdc++-v3/testsuite/22_locale/conversions/buffer/3.cc @@ -0,0 +1,58 @@ +// Copyright (C) 2017 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-do run { target c++11 } } + +#include +#include +#include + +struct streambuf : std::streambuf +{ + int_type underflow() override + { + if (c != '\0') + { + this->setg(&c, &c, &c + 1); + return *this->gptr(); + } + c = '\0'; + return traits_type::eof(); + } + +private: + char c = 'a'; +}; + +struct codecvt : std::codecvt { }; + +void +test01() +{ + // https://gcc.gnu.org/ml/libstdc++/2017-11/msg00022.html + streambuf sb; + std::wbuffer_convert conv(&sb); + VERIFY( sb.in_avail() == 0 ); + wchar_t c = conv.sgetc(); + VERIFY( c == L'a' ); +} + +int +main() +{ + test01(); +}