From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date: Wed, 7 Oct 2020 17:33:00 +0000 (+0100)
Subject: add TODO comments
X-Git-Tag: convert-csv-opcode-to-binary~2052
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d3703fb0f0a06e3971e736a6ca2bc0579b380043;p=libreriscv.git

add TODO comments
---

diff --git a/openpower/sv_analysis.py b/openpower/sv_analysis.py
index 5a051dae6..efea33e24 100644
--- a/openpower/sv_analysis.py
+++ b/openpower/sv_analysis.py
@@ -30,12 +30,21 @@ def blank_key(row):
 
 keycolumns = ['in1', 'in2', 'in3', 'out', 'CR in', 'CR out',
                  'ldst len', 'rc', 'lk']
+
 def create_key(row):
     res = OrderedDict()
     #print ("row", row)
     for key in keycolumns:
-        # registers
-        if key in ['in1', 'in2', 'in3', 'out']:
+        # registers IN
+        if key in ['in1', 'in2', 'in3']:
+            # TODO: replace this with a counter row['in']
+            # will need row['in'] initialising to 0 *outside* of the for-loop
+            if row[key].startswith('R'):
+                res[key] = 'R'
+            else:
+                res[key] = '0'
+        # registers OUT
+        if key == 'out':
             if row[key].startswith('R'):
                 res[key] = 'R'
             else:
@@ -111,7 +120,8 @@ def process_csvs():
     print ("# keys")
     print ()
     print ('[[!table  data="""')
-    print (tformat(keycolumns))
+    print (tformat(keycolumns)) # TODO use alternative here which has
+                                # 'in' rather than in1, in2, in3
 
     for key in primarykeys:
         print (tformat(dictkeys[key].values()))