From: Christian Bruel Date: Thu, 17 Apr 2008 06:49:16 +0000 (+0200) Subject: fix SH long long compare X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d60819f8688af24e3a0cf4264bc0b3e1a06a6255;p=gcc.git fix SH long long compare From-SVN: r134380 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 57d334c17e0..4efd1c0ecc2 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2008-04-17 Christian Bruel + + * config/sh/sh.c (expand_cbranchdi4): Use original operands for + msw_skip comparison. + 2008-04-16 Jakub Jelinek PR c/35739 diff --git a/gcc/config/sh/sh.c b/gcc/config/sh/sh.c index d020ccda582..6b20ee3071d 100644 --- a/gcc/config/sh/sh.c +++ b/gcc/config/sh/sh.c @@ -1685,6 +1685,14 @@ expand_cbranchdi4 (rtx *operands, enum rtx_code comparison) { rtx taken_label = operands[3]; + /* Operands were possibly modified, but msw_skip doesn't expect this. + Always use the original ones. */ + if (msw_taken != CODE_FOR_nothing) + { + operands[1] = op1h; + operands[2] = op2h; + } + operands[3] = skip_label = gen_label_rtx (); expand_cbranchsi4 (operands, msw_skip, msw_skip_prob); operands[3] = taken_label; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index b7349e22069..4ac7a4440ef 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2008-04-17 Christian Bruel + + * gcc.dg/dicomp.c: New testcase. + 2008-04-16 Jerry DeLisle PR fortran/35724 diff --git a/gcc/testsuite/gcc.dg/long-long-compare-1.c b/gcc/testsuite/gcc.dg/long-long-compare-1.c new file mode 100644 index 00000000000..c650cb18d2b --- /dev/null +++ b/gcc/testsuite/gcc.dg/long-long-compare-1.c @@ -0,0 +1,126 @@ +/* Problem only noticed on SH for -mcbranchdi DImode comparison with constants. + * Target dependant failure but test valid for alls. */ +/* { dg-do run } */ +/* { dg-options "-O0" } */ +/* { dg-options "-O0 -mcbranchdi" { target sh4-*-* } } */ + +extern void abort(void); +extern void exit(int); + +int test2(long long n) +{ + if (n < 2) + return 1; + return 0; +} + +int test1(long long n) +{ + if (n < 1) + return 1; + return 0; +} + +int test0(long long n) +{ + if (n < 0) + return 1; + return 0; +} + +int test1n(long long n) +{ + if (n < -1LL) + return 1; + return 0; +} + +int test2n(long long n) +{ + if (n < -2LL) + return 1; + return 0; +} + +int main() +{ + if (test2n (-1LL)) + abort (); + + if (test2n (-2LL)) + abort (); + + if (test2n (0LL)) + abort (); + + if (test2n (1LL)) + abort (); + + if (test2n (2LL)) + abort (); + + if (test1n (-1LL)) + abort (); + + if (!test1n (-2LL)) + abort (); + + if (test1n (0LL)) + abort (); + + if (test1n (1LL)) + abort (); + + if (test1n (2LL)) + abort (); + + if (!test0 (-1LL)) + abort (); + + if (!test0 (-2LL)) + abort (); + + if (test0 (0LL)) + abort (); + + if (test0 (1LL)) + abort (); + + if (test0 (2LL)) + abort (); + + if (!test2 (-1LL)) + abort (); + + if (!test2 (-2LL)) + abort (); + + if (!test2 (0LL)) + abort (); + + if (!test2 (1LL)) + abort (); + + if (test2 (2LL)) + abort (); + + if (!test1 (-1LL)) + abort (); + + if (!test1 (-2LL)) + abort (); + + if (!test1 (0LL)) + abort (); + + if (test1 (1LL)) + abort (); + + if (test1 (2LL)) + abort (); + + exit (0); +} + + +