From: Kyrylo Tkachov Date: Tue, 12 Jul 2016 15:00:28 +0000 (+0000) Subject: [expr.c] PR middle-end/71700: zero-extend sub-word value when widening constructor... X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d6f7c125d85f7b2fb5f8625d4992fbe48f4547d4;p=gcc.git [expr.c] PR middle-end/71700: zero-extend sub-word value when widening constructor element PR middle-end/71700 * expr.c (store_constructor): Mask sign-extended bits when widening sub-word constructor element at the start of a word. * gcc.c-torture/execute/pr71700.c: New test. From-SVN: r238248 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 509e855e95b..ac411d5c3cb 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2016-07-12 Kyrylo Tkachov + + PR middle-end/71700 + * expr.c (store_constructor): Mask sign-extended bits when widening + sub-word constructor element at the start of a word. + 2016-07-12 Martin Liska * ira-build.c (mark_loops_for_removal): Properly iterate diff --git a/gcc/expr.c b/gcc/expr.c index fbc91ad667f..4073a989d96 100644 --- a/gcc/expr.c +++ b/gcc/expr.c @@ -6281,6 +6281,13 @@ store_constructor (tree exp, rtx target, int cleared, HOST_WIDE_INT size, type = lang_hooks.types.type_for_mode (word_mode, TYPE_UNSIGNED (type)); value = fold_convert (type, value); + /* Make sure the bits beyond the original bitsize are zero + so that we can correctly avoid extra zeroing stores in + later constructor elements. */ + tree bitsize_mask + = wide_int_to_tree (type, wi::mask (bitsize, false, + BITS_PER_WORD)); + value = fold_build2 (BIT_AND_EXPR, type, value, bitsize_mask); } if (BYTES_BIG_ENDIAN) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 7dd3c92c4fc..71b52273b68 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2016-07-12 Kyrylo Tkachov + + PR middle-end/71700 + * gcc.c-torture/execute/pr71700.c: New test. + 2016-07-12 Steven Bosscher Richard Biener diff --git a/gcc/testsuite/gcc.c-torture/execute/pr71700.c b/gcc/testsuite/gcc.c-torture/execute/pr71700.c new file mode 100644 index 00000000000..80afd3809c3 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/pr71700.c @@ -0,0 +1,19 @@ +struct S +{ + signed f0 : 16; + unsigned f1 : 1; +}; + +int b; +static struct S c[] = {{-1, 0}, {-1, 0}}; +struct S d; + +int +main () +{ + struct S e = c[0]; + d = e; + if (d.f1 != 0) + __builtin_abort (); + return 0; +}