From: Daniel R. Carvalho <odanrc@yahoo.com.br>
Date: Sat, 26 Dec 2020 01:52:19 +0000 (-0300)
Subject: base: Remove Flags<U> assignment
X-Git-Tag: develop-gem5-snapshot~302
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d7b09c8fce5f79f00ce3baacbbb8b0430d4a20c0;p=gem5.git

base: Remove Flags<U> assignment

Currently unused and broken. Since these are templated classes,
and _flags is private, the assignment is a compilation error.
Furthermore, assignment of flags of different types is likely
undefined behavior.

Change-Id: I8430045c42c003efc74e343cc5b4a4350bc2ad92
Signed-off-by: Daniel R. Carvalho <odanrc@yahoo.com.br>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/38713
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Bobby R. Bruce <bbruce@ucdavis.edu>
Maintainer: Jason Lowe-Power <power.jg@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>
---

diff --git a/src/base/flags.hh b/src/base/flags.hh
index 505a1e54f..8cefd2d33 100644
--- a/src/base/flags.hh
+++ b/src/base/flags.hh
@@ -55,17 +55,6 @@ class Flags
      */
     operator const Type() const { return _flags; }
 
-    /**
-     * @ingroup api_flags
-     */
-    template <typename U>
-    const Flags<T> &
-    operator=(const Flags<U> &flags)
-    {
-        _flags = flags._flags;
-        return *this;
-    }
-
     /**
      * @ingroup api_flags
      */