From: Tom Tromey <tromey@adacore.com>
Date: Thu, 23 Sep 2021 19:09:48 +0000 (-0600)
Subject: Always use std::function for self-tests
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d7c68312bdeca52e242326e5cf155e0aa63268bb;p=binutils-gdb.git

Always use std::function for self-tests

Now that there is a register_test variant that accepts std::function,
it seems to me that the 'selftest' struct and accompanying code is
obsolete -- simply always using std::function is simpler.  This patch
implements this idea.
---

diff --git a/gdbsupport/selftest.cc b/gdbsupport/selftest.cc
index 589ef1e6797..d65063820ac 100644
--- a/gdbsupport/selftest.cc
+++ b/gdbsupport/selftest.cc
@@ -29,43 +29,18 @@ namespace selftests
    the order of tests stable and easily looking up whether a test name
    exists.  */
 
-static std::map<std::string, std::unique_ptr<selftest>> tests;
+static std::map<std::string, std::function<void(void)>> tests;
 
 /* See selftest.h.  */
 
 void
-register_test (const std::string &name, selftest *test)
+register_test (const std::string &name,
+	       std::function<void(void)> function)
 {
   /* Check that no test with this name already exist.  */
   gdb_assert (tests.find (name) == tests.end ());
 
-  tests[name] = std::unique_ptr<selftest> (test);
-}
-
-/* A selftest that calls the test function without arguments.  */
-
-struct lambda_selftest : public selftest
-{
-  lambda_selftest (std::function<void(void)> function_)
-  {
-    function  = function_;
-  }
-
-  void operator() () const override
-  {
-    function ();
-  }
-
-  std::function<void(void)> function;
-};
-
-/* See selftest.h.  */
-
-void
-register_test (const std::string &name,
-	       std::function<void(void)> function)
-{
-  register_test (name, new lambda_selftest (function));
+  tests[name] = function;
 }
 
 /* See selftest.h.  */
@@ -91,7 +66,7 @@ run_tests (gdb::array_view<const char *const> filters, bool verbose)
   for (const auto &pair : tests)
     {
       const std::string &name = pair.first;
-      const std::unique_ptr<selftest> &test = pair.second;
+      const auto &test = pair.second;
       bool run = false;
 
       if (filters.empty ())
@@ -112,7 +87,7 @@ run_tests (gdb::array_view<const char *const> filters, bool verbose)
 	{
 	  debug_printf (_("Running selftest %s.\n"), name.c_str ());
 	  ++ran;
-	  (*test) ();
+	  test ();
 	}
       catch (const gdb_exception_error &ex)
 	{
diff --git a/gdbsupport/selftest.h b/gdbsupport/selftest.h
index d76fc4b37d3..2326ebad495 100644
--- a/gdbsupport/selftest.h
+++ b/gdbsupport/selftest.h
@@ -24,29 +24,15 @@
 /* A test is just a function that does some checks and throws an
    exception if something has gone wrong.  */
 
-typedef void self_test_function (void);
-
 namespace selftests
 {
 
-/* Interface for the various kinds of selftests.  */
-
-struct selftest
-{
-  virtual ~selftest () = default;
-  virtual void operator() () const = 0;
-};
-
 /* True if selftest should run verbosely.  */
 
 extern bool run_verbose ();
 
 /* Register a new self-test.  */
 
-extern void register_test (const std::string &name, selftest *test);
-
-/* Register a new self-test.  */
-
 extern void register_test (const std::string &name,
 			   std::function<void(void)> function);