From: Nick Clifton <nickc@redhat.com>
Date: Fri, 2 Dec 2016 17:46:26 +0000 (+0000)
Subject: Fix seg-fault in linker when passed a corrupt binary input file.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d7f399a8de4c55eb841db6493597a587fac002de;p=binutils-gdb.git

Fix seg-fault in linker when passed a corrupt binary input file.

	PR lf/20908
	* elflink.c (bfd_elf_final_link): Check for ELF flavour binaries
	when following indirect links.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index c8085e7b42c..1fe3cd40e7d 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,9 @@
 2016-12-02  Nick Clifton  <nickc@redhat.com>
 
+	PR lf/20908
+	* elflink.c (bfd_elf_final_link): Check for ELF flavour binaries
+	when following indirect links.
+
 	PR ld/20909
 	* aoutx.h (aout_link_add_symbols): Fix off-by-one error in check
 	for an illegal string offset.
diff --git a/bfd/elflink.c b/bfd/elflink.c
index 5f87f875537..320f3bea433 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -11342,6 +11342,12 @@ bfd_elf_final_link (bfd *abfd, struct bfd_link_info *info)
 	      asection *sec;
 
 	      sec = p->u.indirect.section;
+	      /* See PR 20908 for a reproducer.  */
+	      if (bfd_get_flavour (sec->owner) != bfd_target_elf_flavour)
+		{
+		  _bfd_error_handler (_("%B: not in ELF format"), sec->owner);
+		  goto error_return;
+		}
 	      esdi = elf_section_data (sec);
 
 	      /* Mark all sections which are to be included in the