From: Jim Kingdon <jkingdon@engr.sgi.com>
Date: Thu, 10 Mar 1994 02:33:01 +0000 (+0000)
Subject: 	* libbfd-in.h: Remove alloca cruft.  It was missing some necessary
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d7fb4531821193bd3a57455c59625864f5314dee;p=binutils-gdb.git

	* libbfd-in.h: Remove alloca cruft.  It was missing some necessary
	cruft (like the #pragma alloca for AIX).
	In addition to that problem, the C alloca calls xmalloc, which
	means checking for being out of memory can't work right.  The
	following changes remove all uses of alloca from BFD.
	* hosts/solaris2.h: Remove alloca cruft.
	* som.c: Replace alloca with a fixed size auto array.
	* aoutx.h, elfcode.h, nlmcode.h, bout.c, coff-alpha.c, ecoff.c,
	ecofflink.c, elf32-hppa.c, elf32-mips.c, linker.c, reloc.c, som.c,
	sunos.c: Replace alloca with malloc and appropriate error checking and
	freeing.
	* linker.c: Replace alloca with obstack_alloc.
	* libbfd.h: Rebuilt.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 50c523d7e2b..541cb5f33d3 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -8,8 +8,8 @@ Wed Mar  9 17:17:53 1994  Jim Kingdon  (kingdon@lioth.cygnus.com)
 	* hosts/solaris2.h: Remove alloca cruft.
 	* som.c: Replace alloca with a fixed size auto array.
 	* aoutx.h, elfcode.h, nlmcode.h, bout.c, coff-alpha.c, ecoff.c,
-	ecofflink.c, elf32-hppa.c, elf32-mips.c, linker.c, reloc.c, som.c:
-	Replace alloca with malloc and appropriate error checking and
+	ecofflink.c, elf32-hppa.c, elf32-mips.c, linker.c, reloc.c, som.c,
+	sunos.c: Replace alloca with malloc and appropriate error checking and
 	freeing.
 	* linker.c: Replace alloca with obstack_alloc.
 	* libbfd.h: Rebuilt.
diff --git a/bfd/sunos.c b/bfd/sunos.c
index 59ea75741b4..9d292527d53 100644
--- a/bfd/sunos.c
+++ b/bfd/sunos.c
@@ -87,7 +87,7 @@ sunos_read_dynamic_info (abfd)
 	  bfd_zalloc (abfd, sizeof (struct sunos_dynamic_info)));
   if (!info)
     {
-      bfd_error = no_memory;
+      bfd_set_error (bfd_error_no_memory);
       return false;
     }
   info->valid = false;
@@ -210,7 +210,7 @@ MY(read_dynamic_symbols) (abfd, syms, strs, strsize)
       info->dynstr = (char *) bfd_alloc (abfd, info->dyninfo.ld_symb_size);
       if (!info->dynsym || !info->dynstr)
 	{
-	  bfd_error = no_memory;
+	  bfd_set_error (bfd_error_no_memory);
 	  return 0;
 	}
       if (bfd_seek (abfd, info->dyninfo.ld_stab, SEEK_SET) != 0
@@ -239,7 +239,9 @@ MY(read_dynamic_symbols) (abfd, syms, strs, strsize)
     if (info->dyninfo.ld_buckets > info->dynsym_count)
       abort ();
     table_size = info->dyninfo.ld_stab - info->dyninfo.ld_hash;
-    table = (bfd_byte *) alloca (table_size);
+    table = (bfd_byte *) malloc (table_size);
+    if (table == NULL)
+      abort ();
     if (bfd_seek (abfd, info->dyninfo.ld_hash, SEEK_SET) != 0
 	|| bfd_read ((PTR) table, 1, table_size, abfd) != table_size)
       abort ();
@@ -262,6 +264,7 @@ MY(read_dynamic_symbols) (abfd, syms, strs, strsize)
 	      abort ();
 	  }
       }
+    free (table);
   }
 #endif /* CHECK_DYNAMIC_HASH */
 
@@ -294,7 +297,7 @@ MY(read_dynamic_relocs) (abfd, relocs)
 				       * obj_reloc_entry_size (abfd)));
       if (!info->dynrel)
 	{
-	  bfd_error = no_memory;
+	  bfd_set_error (bfd_error_no_memory);
 	  return (bfd_size_type) -1;
 	}
       if (bfd_seek (abfd, info->dyninfo.ld_rel, SEEK_SET) != 0