From: Scott D Phillips Date: Mon, 19 Mar 2018 22:39:25 +0000 (-0700) Subject: anv: off-by-one in GetDescriptorSetLayoutSupport X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d849d36c6cc99cb7a7ad4b285e3e896d593da07b;p=mesa.git anv: off-by-one in GetDescriptorSetLayoutSupport Loop was accessing one more than bindingCount elements from pBindings, accessing uninitialized memory. Fixes: ddc4069122 ("anv: Implement VK_KHR_maintenance3") Reviewed-by: Nanley Chery Reviewed-by: Lionel Landwerlin --- diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index 2a3c496a9f8..67511e4b286 100644 --- a/src/intel/vulkan/anv_descriptor_set.c +++ b/src/intel/vulkan/anv_descriptor_set.c @@ -42,7 +42,7 @@ void anv_GetDescriptorSetLayoutSupport( { uint32_t surface_count[MESA_SHADER_STAGES] = { 0, }; - for (uint32_t b = 0; b <= pCreateInfo->bindingCount; b++) { + for (uint32_t b = 0; b < pCreateInfo->bindingCount; b++) { const VkDescriptorSetLayoutBinding *binding = &pCreateInfo->pBindings[b]; switch (binding->descriptorType) {