From: Steve Reinhardt <steve.reinhardt@amd.com>
Date: Sat, 4 Jan 2014 01:08:43 +0000 (-0800)
Subject: python: provide better error message for wrapped C++ methods
X-Git-Tag: stable_2014_02_15~1
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=d8c9b5431b05550ee3a232e95af50a5e3d9ce4b5;p=gem5.git

python: provide better error message for wrapped C++ methods

If you successfully export a C++ SimObject method, but try to
invoke it from Python before the C++ object is created, you
get a confusing error that says the attribute does not exist,
making you question whether you successfully exported the
method at all.  In reality, your only problem is that you're
calling the method too soon.  This patch enhances the error
message to give you a better clue.
---

diff --git a/src/python/m5/SimObject.py b/src/python/m5/SimObject.py
index 013f609d6..fc5416cbf 100644
--- a/src/python/m5/SimObject.py
+++ b/src/python/m5/SimObject.py
@@ -724,9 +724,15 @@ class SimObject(object):
         if self._ccObject and hasattr(self._ccObject, attr):
             return getattr(self._ccObject, attr)
 
-        raise AttributeError, "object '%s' has no attribute '%s'" \
+        err_string = "object '%s' has no attribute '%s'" \
               % (self.__class__.__name__, attr)
 
+        if not self._ccObject:
+            err_string += "\n  (C++ object is not yet constructed," \
+                          " so wrapped C++ methods are unavailable.)"
+
+        raise AttributeError, err_string
+
     # Set attribute (called on foo.attr = value when foo is an
     # instance of class cls).
     def __setattr__(self, attr, value):