From: Mark Wielaard <mark@klomp.org>
Date: Tue, 31 May 2022 09:00:06 +0000 (+0200)
Subject: gdb: Always suppress stringop-overread warning in debuginfod-support.c
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=dac0515d825e788dec188fff4d5b9d4ac7383f33;p=binutils-gdb.git

gdb: Always suppress stringop-overread warning in debuginfod-support.c

Just like on s390x with g++ 11.2.1 and ppc64le with g++ 11.3.1 g++ 11
on hppa produces a spurious warning for stringop-overread in
debuginfod_is_enabled for url_view. Just always suppress it on all
arches.

https://sourceware.org/bugzilla/show_bug.cgi?id=29198

gdb/ChangeLog:

	* debuginfod-support.c (debuginfod_is_enabled): Always use
	DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD.
---

diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c
index 6dc08fc29b6..9dbe6b5d8b2 100644
--- a/gdb/debuginfod-support.c
+++ b/gdb/debuginfod-support.c
@@ -193,17 +193,14 @@ debuginfod_is_enabled ()
 	  if (off == gdb::string_view::npos)
 	    break;
 	  url_view = url_view.substr (off);
-#if defined (__s390x__) || defined (__powerpc64__)
-	  /* g++ 11.2.1 on s390x and g++ 11.3.1 on ppc64le seem convinced
-	     url_view might be of SIZE_MAX length.  And so complains
-	     because the length of an array can only be PTRDIFF_MAX.  */
+	  /* g++ 11.2.1 on s390x, g++ 11.3.1 on ppc64le and g++ 11 on
+	     hppa seem convinced url_view might be of SIZE_MAX length.
+	     And so complains because the length of an array can only
+	     be PTRDIFF_MAX.  */
 	  DIAGNOSTIC_PUSH
 	  DIAGNOSTIC_IGNORE_STRINGOP_OVERREAD
-#endif
 	  off = url_view.find_first_of (' ');
-#if defined (__s390x__) || defined (__powerpc64__)
 	  DIAGNOSTIC_POP
-#endif
 	  gdb_printf
 	    (_("  <%ps>\n"),
 	     styled_string (file_name_style.style (),