From: Roland Scheidegger Date: Wed, 10 Dec 2014 18:39:19 +0000 (+0100) Subject: draw: fix another decompose bug affecting constant interpolated attributes X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=db3dfcfe90a3d27e6020e0d3642f8ab0330e57be;p=mesa.git draw: fix another decompose bug affecting constant interpolated attributes Previously the first provoking vertex convention would only be used if flatshading were enabled. No matter how I look at it that cannot be possibly correct. Maybe the code getting used was somewhat simpler that way at a time where there weren't constant interpolated attributes, only flatshading... (Note that all other places including the decomposition macros already do the same.) Reviewed-by: Jose Fonseca --- diff --git a/src/gallium/auxiliary/draw/draw_pt_decompose.h b/src/gallium/auxiliary/draw/draw_pt_decompose.h index 8637085064a..0b2522c08f0 100644 --- a/src/gallium/auxiliary/draw/draw_pt_decompose.h +++ b/src/gallium/auxiliary/draw/draw_pt_decompose.h @@ -3,7 +3,6 @@ const boolean quads_flatshade_last = \ draw->quads_always_flatshade_last; \ const boolean last_vertex_last = \ - !(draw->rasterizer->flatshade && \ - draw->rasterizer->flatshade_first); + !draw->rasterizer->flatshade_first; #include "draw_decompose_tmp.h"