From: Kenneth Graunke Date: Sun, 31 Jul 2011 04:26:26 +0000 (-0700) Subject: mesa: In validate_program(), initialize errMsg for safety. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=db726b048e8858af226dbd0f0fda72d0be01394e;p=mesa.git mesa: In validate_program(), initialize errMsg for safety. validate_program relies on validate_shader_program to fill in errMsg; empirically, there exist cases where that doesn't happen. While tracking those down may be worthwhile, initializing the string so we don't try to ralloc_strdup random garbage also seems wise. Fixes issues caught by valgrind while running some test case. NOTE: This is a candidate for stable release branches. Reviewed-by: Chad Versace Signed-off-by: Kenneth Graunke --- diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 8df25c3f988..74997eaaa77 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -1125,7 +1125,7 @@ static void validate_program(struct gl_context *ctx, GLuint program) { struct gl_shader_program *shProg; - char errMsg[100]; + char errMsg[100] = ""; shProg = _mesa_lookup_shader_program_err(ctx, program, "glValidateProgram"); if (!shProg) {