From: Ian Romanick <ian.d.romanick@intel.com>
Date: Mon, 29 Mar 2010 23:25:56 +0000 (-0700)
Subject: Apply implicit conversions to ?: operator
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=db9be2e7aa3a56e43b725ad7725fe6b424e4933e;p=mesa.git

Apply implicit conversions to ?: operator
---

diff --git a/ast_to_hir.cpp b/ast_to_hir.cpp
index 3450d3889c3..dfb2e40ea3d 100644
--- a/ast_to_hir.cpp
+++ b/ast_to_hir.cpp
@@ -794,18 +794,18 @@ ast_expression::hir(exec_list *instructions,
        *     resulting matching type is the type of the entire
        *     expression."
        */
-      /* FINISHME: Apply implicit conversions */
-      if (op[1]->type == op[2]->type) {
-	 tmp->type = op[1]->type;
-      } else {
+      if ((!apply_implicit_conversion(op[1]->type, & op[2], state)
+	   && !apply_implicit_conversion(op[2]->type, & op[1], state))
+	  || (op[1]->type != op[2]->type)) {
 	 YYLTYPE loc = this->subexpressions[1]->get_location();
 
 	 _mesa_glsl_error(& loc, state, "Second and third operands of ?: "
 			  "operator must have matching types.");
 	 error_emitted = true;
+      } else {
+	 tmp->type = op[1]->type;
       }
 
-
       result = new ir_dereference(tmp);
       type = tmp->type;
       break;