From: Pritha Ghoshal <pritha9987@tamu.edu>
Date: Thu, 10 May 2012 23:04:26 +0000 (-0500)
Subject: IGbE: Fix writeback conditions for i8254x GbE in updated data sheet.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=dc456d8166fce16c3af26f09405b0bf91ff1e38f;p=gem5.git

IGbE: Fix writeback conditions for i8254x GbE in updated data sheet.

An older revision of the data sheet specified that txdctl.gran was 1 the granularity was
based on cache block and gran being 0 is based on descriptor count. The newer version of
the data sheet reverses this errata
---

diff --git a/src/dev/i8254xGBe.cc b/src/dev/i8254xGBe.cc
index effc2a589..29bd5adc2 100644
--- a/src/dev/i8254xGBe.cc
+++ b/src/dev/i8254xGBe.cc
@@ -1923,12 +1923,12 @@ IGbE::TxDescCache::pktComplete()
         igbe->anBegin("TXS", "Desc Writeback");
         DPRINTF(EthernetDesc, "WTHRESH == 0, writing back descriptor\n");
         writeback(0);
-    } else if (igbe->regs.txdctl.gran() && igbe->regs.txdctl.wthresh() >=
+    } else if (!igbe->regs.txdctl.gran() && igbe->regs.txdctl.wthresh() <=
                descInBlock(usedCache.size())) {
         DPRINTF(EthernetDesc, "used > WTHRESH, writing back descriptor\n");
         igbe->anBegin("TXS", "Desc Writeback");
         writeback((igbe->cacheBlockSize()-1)>>4);
-    } else if (igbe->regs.txdctl.wthresh() >= usedCache.size()) {
+    } else if (igbe->regs.txdctl.wthresh() <= usedCache.size()) {
         DPRINTF(EthernetDesc, "used > WTHRESH, writing back descriptor\n");
         igbe->anBegin("TXS", "Desc Writeback");
         writeback((igbe->cacheBlockSize()-1)>>4);