From: Roland Scheidegger Date: Mon, 17 Dec 2012 21:06:40 +0000 (+0100) Subject: gallivm: fix conversion for pure integer formats X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=dc613f11ddf1f3a6e10c2d99830fb1a84fdb55b2;p=mesa.git gallivm: fix conversion for pure integer formats Since the idea is to just expand or shrink the bit width but not otherwise do conversion we also need to adjust the sign bit according to src, otherwise the conversion code will incorrectly clamp the values. (Since this only works for casting to ordinary floats the norm and fixed bits should always be fine.) This fixes the remaining piglit attribs GL3 failures. Reviewed-by: José Fonseca --- diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_aos_array.c b/src/gallium/auxiliary/gallivm/lp_bld_format_aos_array.c index 1eb94466280..9642b9ecfed 100644 --- a/src/gallium/auxiliary/gallivm/lp_bld_format_aos_array.c +++ b/src/gallium/auxiliary/gallivm/lp_bld_format_aos_array.c @@ -150,6 +150,7 @@ lp_build_fetch_rgba_aos_array(struct gallivm_state *gallivm, if (pure_integer) { assert(dst_type.floating); tmp_type.floating = 0; + tmp_type.sign = src_type.sign; } /* Convert to correct format */