From: Zack Rusin <zackr@vmware.com>
Date: Tue, 30 Mar 2010 12:55:17 +0000 (-0400)
Subject: gallivm: cleanup the code (found by coverity)
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=dc886ba1391d7d890bd1f5532bc14553e883a418;p=mesa.git

gallivm: cleanup the code (found by coverity)

the condition can't be false, declerations are ok even if we don't
emit any.
---

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
index 95cd6a0ecf3..8901e656aed 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
@@ -666,30 +666,20 @@ emit_declaration(
                              first_inst);
 
    for (idx = first; idx <= last; ++idx) {
-      boolean ok;
-
       switch (decl->Declaration.File) {
       case TGSI_FILE_TEMPORARY:
          for (i = 0; i < NUM_CHANNELS; i++)
             bld->temps[idx][i] = lp_build_alloca(&bld->base);
-         ok = TRUE;
          break;
 
       case TGSI_FILE_OUTPUT:
          for (i = 0; i < NUM_CHANNELS; i++)
             bld->outputs[idx][i] = lp_build_alloca(&bld->base);
-         ok = TRUE;
          break;
 
       default:
          /* don't need to declare other vars */
-         ok = TRUE;
-      }
-
-      if (!ok) {
-         LLVMPositionBuilderAtEnd(bld->base.builder,
-                                  current_block);
-         return FALSE;
+         break;
       }
    }