From: Kenneth Graunke Date: Wed, 21 Nov 2012 01:02:23 +0000 (-0800) Subject: i965/fs: Abort on unsupported opcodes rather than failing. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=dd1fd300473bd58929e5a1b1a5e5a0e82af9d7cf;p=mesa.git i965/fs: Abort on unsupported opcodes rather than failing. Final code generation should never fail. This is a bug, and there should be no user-triggerable cases where this could occur. Also, we're not going to have a fail() method in a moment. v2: Just abort() rather than assert, to cover the NDEBUG case (suggested by Eric). Reviewed-by: Eric Anholt Reviewed-by: Paul Berry --- diff --git a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp index 4a1700b8fdb..f04d90db1f7 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_emit.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs_emit.cpp @@ -1012,7 +1012,7 @@ fs_visitor::generate_code() } else { _mesa_problem(ctx, "Unsupported opcode %d in FS", inst->opcode); } - fail("unsupported opcode in FS\n"); + abort(); } if (unlikely(INTEL_DEBUG & DEBUG_WM)) {