From: Yann E. MORIN Date: Tue, 17 Mar 2015 15:14:55 +0000 (+0100) Subject: toolchain/external: do not accept distro-class toolchains X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=defb9658935357aca034276df4e78ac9b12c38ee;p=buildroot.git toolchain/external: do not accept distro-class toolchains Distro toolchains, i.ie. toolchains coing with distributions, will almost invariably be unsuitable for use with Buildroot: - they are mostly non-relocatable; - their sysroot is tainted with a lot of extra libraries. Especially, the toolchains coming with Ubuntu (really, all the Debian familly of distros) are configured with --sysroot=/ which makes them non-relocatable, and they already contain quite some libraries that conflict (in any combination of version, API or ABI) with what Buildroot wants to build (i.e. extra libraries, some not even present in Buildroot...) but also their mere preence when Buildroot does not expect them to be already built (so that a package would enable features when it should not). So, try to detect those toolchains and black-list them; inform the user that the toolchain is unusable for the reasons mentioned above. Signed-off-by: "Yann E. MORIN" Cc: Thomas Petazzoni Cc: Arnout Vandecappelle Signed-off-by: Thomas Petazzoni --- diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk index 50446ce914..257fab23f1 100644 --- a/toolchain/helpers.mk +++ b/toolchain/helpers.mk @@ -357,6 +357,14 @@ check_unusable_toolchain = \ echo "them unsuitable as external toolchains for build systems" ; \ echo "such as Buildroot." ; \ exit 1 ; \ + fi; \ + with_sysroot=`$${__CROSS_CC} -v 2>&1 |sed -r -e '/.* --with-sysroot=([^[:space:]]+)[[:space:]].*/!d; s//\1/'`; \ + if test "$${with_sysroot}" = "/" ; then \ + echo "Distribution toolchains are unsuitable for use by Buildroot," ; \ + echo "as they were configured in a way that makes them non-relocatable,"; \ + echo "and contain a lot of pre-built libraries that would conflict with"; \ + echo "the ones Buildroot wants to build."; \ + exit 1; \ fi #