From: Steve Reinhardt Date: Wed, 22 Oct 2014 22:53:34 +0000 (-0700) Subject: syscall_emul: devirtualize BaseBufferArg methods X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=df7f0892ed5f4522a4582aaed7e49622e3a33d9f;p=gem5.git syscall_emul: devirtualize BaseBufferArg methods Not clear why they were marked virtual to begin with, but that doesn't appear to be necessary. --- diff --git a/src/sim/syscall_emul_buf.hh b/src/sim/syscall_emul_buf.hh index cbd10f2f6..e930846be 100644 --- a/src/sim/syscall_emul_buf.hh +++ b/src/sim/syscall_emul_buf.hh @@ -70,12 +70,12 @@ class BaseBufferArg { memset(bufPtr, 0, size); } - virtual ~BaseBufferArg() { delete [] bufPtr; } + ~BaseBufferArg() { delete [] bufPtr; } /** * copy data into simulator space (read from target memory) */ - virtual bool copyIn(SETranslatingPortProxy &memproxy) + bool copyIn(SETranslatingPortProxy &memproxy) { memproxy.readBlob(addr, bufPtr, size); return true; // no EFAULT detection for now @@ -84,7 +84,7 @@ class BaseBufferArg { /** * copy data out of simulator space (write to target memory) */ - virtual bool copyOut(SETranslatingPortProxy &memproxy) + bool copyOut(SETranslatingPortProxy &memproxy) { memproxy.writeBlob(addr, bufPtr, size); return true; // no EFAULT detection for now