From: Eli Zaretskii <eliz@gnu.org>
Date: Wed, 15 Mar 2000 11:10:52 +0000 (+0000)
Subject: * ser-go32.c (dos_get_tty_state): Fail if the (fake) handle was
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=dfed996b3b77d0ff05a53f777148ab0ecfe58d5d;p=binutils-gdb.git

* ser-go32.c (dos_get_tty_state): Fail if the (fake) handle was
not opened by dos_open, but let the 3 standard handles go through
unharmed.
---

diff --git a/gdb/ser-go32.c b/gdb/ser-go32.c
index 0474000e61a..1d5eea23449 100644
--- a/gdb/ser-go32.c
+++ b/gdb/ser-go32.c
@@ -488,6 +488,10 @@ dos_open (scb, name)
       return -1;
     }
 
+  /* FIXME: this is a Bad Idea (tm)!  One should *never* invent file
+     handles, since they might be already used by other files/devices.
+     The Right Way to do this is to create a real handle by dup()'ing
+     some existing one.  */
   fd = name[3] - '1';
   port = &ports[fd];
   if (port->refcnt++ > 0)
@@ -650,6 +654,19 @@ dos_get_tty_state (scb)
   struct dos_ttystate *port = &ports[scb->fd];
   struct dos_ttystate *state;
 
+  /* Are they asking about a port we opened?  */
+  if (port->refcnt <= 0)
+    {
+      /* We've never heard about this port.  We should fail this call,
+	 unless they are asking about one of the 3 standard handles,
+	 in which case we pretend the handle was open by us if it is
+	 connected to a terminal device.  This is beacuse Unix
+	 terminals use the serial interface, so GDB expects the
+	 standard handles to go through here.  */
+      if (scb->fd >= 3 || !isatty (scb->fd))
+	return NULL;
+    }
+
   state = (struct dos_ttystate *) xmalloc (sizeof *state);
   *state = *port;
   return (serial_ttystate) state;