From: Kenneth Graunke <kenneth@whitecape.org>
Date: Wed, 25 Aug 2010 23:37:46 +0000 (-0700)
Subject: glsl: Remove name_declared_this_scope check when adding functions.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=e09591317b2470fe9c104606577d4e10255727c0;p=mesa.git

glsl: Remove name_declared_this_scope check when adding functions.

Instead, rely on the symbol table's rules.

Fixes redeclaration-02.vert.
---

diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 8c105e79f71..8caf950c2d2 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -2197,17 +2197,16 @@ ast_function::hir(exec_list *instructions,
 	    _mesa_glsl_error(& loc, state, "function `%s' redefined", name);
 	 }
       }
-   } else if (state->symbols->name_declared_this_scope(name)) {
-      /* This function name shadows a non-function use of the same name.
-       */
-      YYLTYPE loc = this->get_location();
-
-      _mesa_glsl_error(& loc, state, "function name `%s' conflicts with "
-		       "non-function", name);
-      return NULL;
    } else {
       f = new(ctx) ir_function(name);
-      state->symbols->add_function(f->name, f);
+      if (!state->symbols->add_function(f->name, f)) {
+	 /* This function name shadows a non-function use of the same name. */
+	 YYLTYPE loc = this->get_location();
+
+	 _mesa_glsl_error(&loc, state, "function name `%s' conflicts with "
+			  "non-function", name);
+	 return NULL;
+      }
 
       /* Emit the new function header */
       instructions->push_tail(f);