From: Cesar Strauss <cestrauss@gmail.com>
Date: Sat, 6 Mar 2021 16:46:50 +0000 (-0300)
Subject: Make the raw opcode input port of the decoder stay stable
X-Git-Tag: convert-csv-opcode-to-binary~103
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=e09a02c286ee629f01e094c2bff9ce53f20160b8;p=soc.git

Make the raw opcode input port of the decoder stay stable

During a Simple-V loop, the decoder will be reused repeatedly, so its
raw opcode input needs to hold stable. An alternate way would be to
pass the raw opcode and the SVP64 RM field to the issue FSM, so it could
supply these decoder inputs when needed.
---

diff --git a/src/soc/simple/issuer.py b/src/soc/simple/issuer.py
index 72b432da..877c7382 100644
--- a/src/soc/simple/issuer.py
+++ b/src/soc/simple/issuer.py
@@ -161,11 +161,7 @@ class TestIssuerInternal(Elaboratable):
         pdecode2 = self.pdecode2
         svp64 = self.svp64
         cur_state = self.cur_state
-
-        # latches copy of raw fetched instruction
-        fetch_insn_o = Signal(32, reset_less=True)
         dec_opcode_i = pdecode2.dec.raw_opcode_in # raw opcode
-        sync += dec_opcode_i.eq(fetch_insn_o)  # actual opcode
 
         msr_read = Signal(reset=1)
 
@@ -215,7 +211,7 @@ class TestIssuerInternal(Elaboratable):
                     with m.If(~svp64.is_svp64_mode):
                         # with no prefix, store the instruction
                         # and hand it directly to the next FSM
-                        comb += fetch_insn_o.eq(insn)
+                        sync += dec_opcode_i.eq(insn)
                         m.next = "INSN_READY"
                     with m.Else():
                         # fetch the rest of the instruction from memory
@@ -232,7 +228,7 @@ class TestIssuerInternal(Elaboratable):
                 with m.Else():
                     # not busy: instruction fetched
                     insn = get_insn(self.imem.f_instr_o, cur_state.pc+4)
-                    comb += fetch_insn_o.eq(insn)
+                    sync += dec_opcode_i.eq(insn)
                     m.next = "INSN_READY"
 
             with m.State("INSN_READY"):