From: Timothy Arceri <tarceri@itsqueeze.com>
Date: Thu, 6 Feb 2020 01:49:10 +0000 (+1100)
Subject: glsl: fix resizing of the uniform remap table
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=e0aa0a839f9c168784a1f50013c83877cc876094;p=mesa.git

glsl: fix resizing of the uniform remap table

In the NIR linker we were not resizing the remap table correctly
for explicit locations when it was needed.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3992>
---

diff --git a/src/compiler/glsl/gl_nir_link_uniforms.c b/src/compiler/glsl/gl_nir_link_uniforms.c
index 7196d8b2c1f..7249829c564 100644
--- a/src/compiler/glsl/gl_nir_link_uniforms.c
+++ b/src/compiler/glsl/gl_nir_link_uniforms.c
@@ -105,16 +105,20 @@ nir_setup_uniform_remap_tables(struct gl_context *ctx,
       unsigned location =
          link_util_find_empty_block(prog, &prog->data->UniformStorage[i]);
 
-      if (location == -1) {
-         location = prog->NumUniformRemapTable;
+      if (location == -1 || location + entries >= prog->NumUniformRemapTable) {
+         unsigned new_entries = entries;
+         if (location == -1)
+            location = prog->NumUniformRemapTable;
+         else
+            new_entries = location - prog->NumUniformRemapTable + entries;
 
          /* resize remap table to fit new entries */
          prog->UniformRemapTable =
             reralloc(prog,
                      prog->UniformRemapTable,
                      struct gl_uniform_storage *,
-                     prog->NumUniformRemapTable + entries);
-         prog->NumUniformRemapTable += entries;
+                     prog->NumUniformRemapTable + new_entries);
+         prog->NumUniformRemapTable += new_entries;
       }
 
       /* set the base location in remap table for the uniform */