From: Gabriel Krisman Bertazi <gabriel@krisman.be>
Date: Sun, 19 Apr 2015 22:34:08 +0000 (-0300)
Subject: Remove duplicated xmalloc in update_dprintf_command_list
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=e31d7699a0b116025b48f1ab5214eddd2e56ef9f;p=binutils-gdb.git

Remove duplicated xmalloc in update_dprintf_command_list

Code in update_dprintf_command_list performed a duplicated memory
allocation which caused an obvious memory leak.  This removes the
duplication.

gdb/
2015-04-19  Gabriel Krisman Bertazi  <gabriel@krisman.be>

	* breakpoint.c (update_dprintf_command_list): Remove duplicated
	xmalloc.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4bca7d6fdd9..f878a1a3fb3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-04-19  Gabriel Krisman Bertazi  <gabriel@krisman.be>
+
+	* breakpoint.c (update_dprintf_command_list): Remove duplicated
+	xmalloc.
+
 2015-04-20  Thomas Schwinge  <thomas@codesourcery.com>
 
 	* reply_mig_hack.awk: Robustify parsing.
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 31869f1d263..a3531a01cc1 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -9057,7 +9057,6 @@ update_dprintf_command_list (struct breakpoint *b)
     struct command_line *printf_cmd_line
       = xmalloc (sizeof (struct command_line));
 
-    printf_cmd_line = xmalloc (sizeof (struct command_line));
     printf_cmd_line->control_type = simple_control;
     printf_cmd_line->body_count = 0;
     printf_cmd_line->body_list = NULL;