From: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Date: Mon, 27 May 2019 21:06:03 +0000 (+0300)
Subject: virgl: Remove incorrect resource wait condition
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=e34f79c9182f0beafaec6d254df168515e219568;p=mesa.git

virgl: Remove incorrect resource wait condition

Now that we have copy transfers in place, we can remove the incorrect
resource wait condition. Copy transfers and other optimizations minimize
the performance impact of this removal, while providing the correct
behavior.

Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
---

diff --git a/src/gallium/drivers/virgl/virgl_resource.c b/src/gallium/drivers/virgl/virgl_resource.c
index 897e0c16c7e..879c3fb359a 100644
--- a/src/gallium/drivers/virgl/virgl_resource.c
+++ b/src/gallium/drivers/virgl/virgl_resource.c
@@ -155,19 +155,6 @@ virgl_resource_transfer_prepare(struct virgl_context *vctx,
          flush = true;
    }
 
-   /* XXX This is incorrect and will be removed.  Consider
-    *
-    *   glTexImage2D(..., data1);
-    *   glDrawArrays();
-    *   glFlush();
-    *   glTexImage2D(..., data2);
-    *
-    * readback and flush are both false in the second glTexImage2D call.  The
-    * draw call might end up seeing data2.  Same applies to buffers with
-    * glBufferSubData.
-    */
-   wait = flush || readback;
-
    if (flush)
       vctx->base.flush(&vctx->base, NULL, 0);