From: Christopher Faylor <me+cygwin@cgf.cx>
Date: Fri, 17 Nov 2000 03:49:41 +0000 (+0000)
Subject: * thread.c (thread_apply_all_command): Save the command before executing it
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=e35ce267f5838c87c6fdfaec396c2f2600c478c0;p=binutils-gdb.git

* thread.c (thread_apply_all_command): Save the command before executing it
because it may be modified.  Restore the saved command so that the same command
is executed on next thread.
(thread_apply_command): Same correction.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8507debe8c8..8df4bd4e4ff 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2000-11-16  Christopher Faylor  <cgf@redhat.com>
+
+	* thread.c (thread_apply_all_command): Save the command before
+	executing it because it may be modified.  Restore the saved command so
+	that the same command is executed on next thread.
+	(thread_apply_command): Same correction.
+
 2000-11-16  Michael Snyder  <msnyder@cleaver.cygnus.com>
 
 	* regcache.c (read_register_bytes): Failing to set register_valid
diff --git a/gdb/thread.c b/gdb/thread.c
index 94f0b3f3791..7f509765b9c 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -517,6 +517,8 @@ thread_apply_all_command (char *cmd, int from_tty)
 {
   struct thread_info *tp;
   struct cleanup *old_chain;
+  struct cleanup *saved_cmd_cleanup_chain;
+  char *saved_cmd;
 
   if (cmd == NULL || *cmd == '\000')
     error ("Please specify a command following the thread ID list");
@@ -527,6 +529,10 @@ thread_apply_all_command (char *cmd, int from_tty)
      traversing it for "thread apply all".  MVS */
   target_find_new_threads ();
 
+  /* Save a copy of the command in case it is clobbered by
+     execute_command */
+  saved_cmd = strdup (cmd);
+  saved_cmd_cleanup_chain = make_cleanup (free, (void *) saved_cmd);
   for (tp = thread_list; tp; tp = tp->next)
     if (thread_alive (tp))
       {
@@ -540,8 +546,10 @@ thread_apply_all_command (char *cmd, int from_tty)
 			 target_pid_to_str (inferior_pid));
 #endif
 	execute_command (cmd, from_tty);
+	strcpy (cmd, saved_cmd); /* Restore exact command used previously */
       }
 
+  do_cleanups (saved_cmd_cleanup_chain);
   do_cleanups (old_chain);
 }
 
@@ -551,6 +559,8 @@ thread_apply_command (char *tidlist, int from_tty)
   char *cmd;
   char *p;
   struct cleanup *old_chain;
+  struct cleanup *saved_cmd_cleanup_chain;
+  char *saved_cmd;
 
   if (tidlist == NULL || *tidlist == '\000')
     error ("Please specify a thread ID list");
@@ -562,6 +572,10 @@ thread_apply_command (char *tidlist, int from_tty)
 
   old_chain = make_cleanup_restore_current_thread (inferior_pid);
 
+  /* Save a copy of the command in case it is clobbered by
+     execute_command */
+  saved_cmd = strdup (cmd);
+  saved_cmd_cleanup_chain = make_cleanup (free, (void *) saved_cmd);
   while (tidlist < cmd)
     {
       struct thread_info *tp;
@@ -608,10 +622,12 @@ thread_apply_command (char *tidlist, int from_tty)
 			       target_pid_to_str (inferior_pid));
 #endif
 	      execute_command (cmd, from_tty);
+	      strcpy (cmd, saved_cmd);	/* Restore exact command used previously */
 	    }
 	}
     }
 
+  do_cleanups (saved_cmd_cleanup_chain);
   do_cleanups (old_chain);
 }