From: Andrew Burgess <aburgess@redhat.com>
Date: Wed, 12 Oct 2022 10:14:26 +0000 (+0100)
Subject: sim/ppc: mark device_error function as ATTRIBUTE_NORETURN
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=e5961d2be503149aaa40927c0a9501c06ca980e5;p=binutils-gdb.git

sim/ppc: mark device_error function as ATTRIBUTE_NORETURN

The device_error function always ends up calling the error function,
which is itself marked as ATTRIBUTE_NORETURN, so it makes sense that
device_error should also be marked ATTRIBUTE_NORETURN.

Doing this resolves a few warnings from hw_ide.c about possibly
uninitialized variables - the variables are only uninitialized after
passing through a call to device_error, which obviously means the
variables are never really used uninitialized, the simulation will
terminate with the device_error call.
---

diff --git a/sim/ppc/device.h b/sim/ppc/device.h
index bd539095160..65c85e4ddd3 100644
--- a/sim/ppc/device.h
+++ b/sim/ppc/device.h
@@ -729,7 +729,7 @@ EXTERN_DEVICE\
 (void) device_error
 (device *me,
  const char *fmt,
- ...) ATTRIBUTE_PRINTF_2;
+ ...) ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF_2;
 
 INLINE_DEVICE\
 (int) device_trace