From: Yao Qi <yao@codesourcery.com>
Date: Sun, 8 Dec 2013 02:34:34 +0000 (+0800)
Subject: Avoid "may be used uninitialized" warning
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=e5e6f788e45ebdcf46c3a24f68994851186aa839;p=binutils-gdb.git

Avoid "may be used uninitialized" warning

Hi,
I see such warning below on one compiler I am using.

cc1: warnings being treated as errors
../../workspace/gdb/stack.c: In function 'frame_info':
../../workspace/gdb/stack.c:1519:20: error: 'caller_pc' may be used uninitialized in this function

Go through the gdb-patches archives and find the "canonical" way to
fix this warning is to initialize the variable.

gdb:

2013-12-08  Yao Qi  <yao@codesourcery.com>

	* stack.c (frame_info): Initialize variable caller_pc.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 474839254de..252aa697b69 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2013-12-08  Yao Qi  <yao@codesourcery.com>
+
+	* stack.c (frame_info): Initialize variable caller_pc.
+
 2013-12-06  Pedro Alves  <palves@redhat.com>
 
 	* frame.c (enum cached_copy_status): New enum.
diff --git a/gdb/stack.c b/gdb/stack.c
index 848bcb0a262..f45bb8050a4 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -1407,7 +1407,8 @@ frame_info (char *addr_exp, int from_tty)
   struct cleanup *back_to = make_cleanup (null_cleanup, NULL);
   CORE_ADDR frame_pc;
   int frame_pc_p;
-  CORE_ADDR caller_pc;
+  /* Initialize it to avoid "may be used uninitialized" warning.  */
+  CORE_ADDR caller_pc = 0;
   volatile struct gdb_exception ex;
 
   fi = parse_frame_specification_1 (addr_exp, "No stack.", &selected_frame_p);