From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date: Mon, 8 Nov 2021 13:59:16 +0000 (+0000)
Subject: convert core.py to Pipeline API, deriving from ControlBase
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=e93ce0ad7048c48008c356c831ed9ea9e2bdfa66;p=soc.git

convert core.py to Pipeline API, deriving from ControlBase
---

diff --git a/src/soc/simple/core.py b/src/soc/simple/core.py
index 368c2272..67337460 100644
--- a/src/soc/simple/core.py
+++ b/src/soc/simple/core.py
@@ -29,6 +29,7 @@ from openpower.sv.svp64 import SVP64Rec
 
 from nmutil.picker import PriorityPicker
 from nmutil.util import treereduce
+from nmutil.singlepipe import ControlBase
 
 from soc.fu.compunits.compunits import AllFunctionUnits
 from soc.regfile.regfiles import RegFiles
@@ -119,7 +120,9 @@ class CoreOutput:
         self.core_terminate_o.eq(i.core_terminate_o)
 
 
-class NonProductionCore(Elaboratable):
+# derive from ControlBase rather than have a separate Stage instance,
+# this is simpler to do
+class NonProductionCore(ControlBase):
     def __init__(self, pspec):
         self.pspec = pspec
 
@@ -130,6 +133,8 @@ class NonProductionCore(Elaboratable):
         self.regreduce_en = (hasattr(pspec, "regreduce") and
                              (pspec.regreduce == True))
 
+        super().__init__(stage=self)
+
         # single LD/ST funnel for memory access
         self.l0 = l0 = TstL0CacheBuffer(pspec, n_units=1)
         pi = l0.l0.dports[0]
@@ -149,9 +154,11 @@ class NonProductionCore(Elaboratable):
         # register files (yes plural)
         self.regs = RegFiles(pspec)
 
-        # set up input and output
-        self.i = CoreInput(pspec, self.svp64_en, self.regreduce_en)
-        self.o = CoreOutput()
+        # set up input and output: unusual requirement to set data directly
+        # (due to the way that the core is set up in a different domain,
+        # see TestIssuer.setup_peripherals
+        self.i, self.o = self.new_specs(None)
+        self.i, self.o = self.p.i_data, self.n.o_data
 
         # create per-FU instruction decoders (subsetted)
         self.decoders = {}
@@ -175,8 +182,18 @@ class NonProductionCore(Elaboratable):
         if "mmu0" in self.decoders:
             self.decoders["mmu0"].mmu0_spr_dec = self.decoders["spr0"]
 
+    def setup(self, m, i):
+        pass
+
+    def ispec(self):
+        return CoreInput(self.pspec, self.svp64_en, self.regreduce_en)
+
+    def ospec(self):
+        return CoreOutput()
+
     def elaborate(self, platform):
-        m = Module()
+        m = super().elaborate(platform)
+
         # for testing purposes, to cut down on build time in coriolis2
         if hasattr(self.pspec, "nocore") and self.pspec.nocore == True:
             x = Signal() # dummy signal