From: Alan Modra <amodra@gmail.com>
Date: Mon, 24 Apr 2023 11:30:00 +0000 (+0930)
Subject: Revert "x86: work around compiler diagnosing dangling pointer"
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ea5c591c023544e40bb4967314a47d8e6a1e806d;p=binutils-gdb.git

Revert "x86: work around compiler diagnosing dangling pointer"

This reverts commit 983db9932a302f9e2ae1f1d4fd7c3149560bc269.
---

diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c
index 1fe54289655..01e5ba81723 100644
--- a/opcodes/i386-dis.c
+++ b/opcodes/i386-dis.c
@@ -345,12 +345,6 @@ fetch_error (const instr_info *ins)
   const struct dis_private *priv = ins->info->private_data;
   const char *name = NULL;
 
-  /* Our caller has put a pointer to a local variable in info->private_data
-     and it is going to return right after this function has returned.  Some
-     compilers diagnose this as a dangling pointer.  Zap the pointer here to
-     avoid needing to do so on all involved return paths in the caller.  */
-  ins->info->private_data = NULL;
-
   if (ins->codep <= priv->the_buffer)
     return -1;