From: Tom de Vries <tdevries@suse.de>
Date: Wed, 7 Oct 2020 05:22:43 +0000 (+0200)
Subject: [tree-ssa-loop-ch] Add missing NULL test for dump_file
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ebc77ce3a4c70730b4e38d68f88693eadbdc8712;p=gcc.git

[tree-ssa-loop-ch] Add missing NULL test for dump_file

If we change gimple_can_duplicate_bb_p to return false instead of true, we run
into a segfault in ch_base::copy_headers due to using dump_file while it's
NULL:
...
      if (!gimple_duplicate_sese_region (entry, exit, bbs, n_bbs, copied_bbs,
                                        true))
       {
         fprintf (dump_file, "Duplication failed.\n");
         continue;
       }
...

Fix this by adding the missing dump_file != NULL test.

Tested by rebuilding lto1 and rerunning the failing test-case.

gcc/ChangeLog:

2020-10-07  Tom de Vries  <tdevries@suse.de>

	* tree-ssa-loop-ch.c (ch_base::copy_headers): Add missing NULL test
	for dump_file.
---

diff --git a/gcc/tree-ssa-loop-ch.c b/gcc/tree-ssa-loop-ch.c
index b86acf7c39d..1f3d9321a55 100644
--- a/gcc/tree-ssa-loop-ch.c
+++ b/gcc/tree-ssa-loop-ch.c
@@ -425,7 +425,8 @@ ch_base::copy_headers (function *fun)
       if (!gimple_duplicate_sese_region (entry, exit, bbs, n_bbs, copied_bbs,
 					 true))
 	{
-	  fprintf (dump_file, "Duplication failed.\n");
+	  if (dump_file && (dump_flags & TDF_DETAILS))
+	    fprintf (dump_file, "Duplication failed.\n");
 	  continue;
 	}
       copied.safe_push (std::make_pair (entry, loop));