From: Maciej W. Rozycki <macro@mips.com>
Date: Tue, 20 Mar 2018 11:48:59 +0000 (+0000)
Subject: gc.exp: Remove extraneous LD flags from the personality test
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ed3818775569116d7f09df3d81e22cb8169a8c06;p=binutils-gdb.git

gc.exp: Remove extraneous LD flags from the personality test

Complement commit 8988502d7534 ("MIPS/LD/testsuite: Correct dynamic
links with VR4100, VR4300 and VR5000") and commit bf48520113c4 ("gc.exp:
Fix a typo: $LFLAGS -> $LDFLAGS"), and remove extraneous additional LD
flags explicitly passed to the personality test on invocation.  This
passing has accidentally leaked from a WIP version of the former change.

With the actual version committed the $LDFLAGS global variable is used
instead for `run_dump_test' to use implicitly, so that `-call_shared'
precedes `-lpersonality' on the linker's command line, as otherwise a
shared `libpersonality.so' library wouldn't be considered for linking,
causing the test to fail.

	ld/
	* testsuite/ld-gc/gc.exp: Remove extraneous LD flags from the
	personality test.
---

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 2eaf710e9c8..7270ac0d317 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@
+2018-03-20  Maciej W. Rozycki  <macro@mips.com>
+
+	* testsuite/ld-gc/gc.exp: Remove extraneous LD flags from the
+	personality test.
+
 2018-03-20  H.J. Lu  <hongjiu.lu@intel.com>
 
 	PR ld/22983
diff --git a/ld/testsuite/ld-gc/gc.exp b/ld/testsuite/ld-gc/gc.exp
index efdddd74522..75d57148a35 100644
--- a/ld/testsuite/ld-gc/gc.exp
+++ b/ld/testsuite/ld-gc/gc.exp
@@ -127,7 +127,7 @@ if { [is_elf_format] && [check_shared_lib_support] } then {
 	|| ![ld_link $ld tmpdir/libpersonality.so "-shared tmpdir/libpersonality.o"] } then {
 	fail libpersonality
     } else {
-	run_dump_test "personality" [list [list ld $LDFLAGS]]
+	run_dump_test "personality"
     }
     run_dump_test "pr18223"
     if {![ld_assemble_flags $as $gasopt $srcdir/$subdir/pr20022a.s tmpdir/pr20022a.o]