From: Emil Velikov <emil.l.velikov@gmail.com>
Date: Sat, 14 May 2016 15:33:11 +0000 (+0100)
Subject: st/xa: don't call close(-1) in xa_tracker_create error path
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ed3f6ccce0f4fdc25705dd8c0beea8e9325db57f;p=mesa.git

st/xa: don't call close(-1) in xa_tracker_create error path

Analogous to previous commit.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
---

diff --git a/src/gallium/state_trackers/xa/xa_tracker.c b/src/gallium/state_trackers/xa/xa_tracker.c
index f09baed1d84..e091b083411 100644
--- a/src/gallium/state_trackers/xa/xa_tracker.c
+++ b/src/gallium/state_trackers/xa/xa_tracker.c
@@ -152,7 +152,7 @@ xa_tracker_create(int drm_fd)
     struct xa_tracker *xa = calloc(1, sizeof(struct xa_tracker));
     enum xa_surface_type stype;
     unsigned int num_formats;
-    int fd = -1;
+    int fd;
 
     if (!xa)
 	return NULL;
@@ -212,9 +212,9 @@ xa_tracker_create(int drm_fd)
  out_no_screen:
     if (xa->dev)
 	pipe_loader_release(&xa->dev, 1);
-    fd = -1;
+    else
+	close(fd);
  out_no_fd:
-    close(fd);
     free(xa);
     return NULL;
 }