From: Tom Tromey <tromey@adacore.com>
Date: Fri, 22 Jul 2022 18:55:27 +0000 (-0600)
Subject: Remove dead code from windows_nat_target::detach
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=eea2d83593428d2ac18f6b3fc43cff5472521579;p=binutils-gdb.git

Remove dead code from windows_nat_target::detach

windows_nat_target::detach has a variable 'detached' that is only set
after a call to 'error'.  However, this can't happen because 'error'
throws an exception.

This patch removes the dead code.
---

diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c
index 43a2c112db5..9265ed9e632 100644
--- a/gdb/windows-nat.c
+++ b/gdb/windows-nat.c
@@ -1912,22 +1912,16 @@ windows_nat_target::attach (const char *args, int from_tty)
 void
 windows_nat_target::detach (inferior *inf, int from_tty)
 {
-  int detached = 1;
-
   ptid_t ptid = minus_one_ptid;
   resume (ptid, 0, GDB_SIGNAL_0);
 
   if (!DebugActiveProcessStop (windows_process.current_event.dwProcessId))
-    {
-      error (_("Can't detach process %u (error %u)"),
-	     (unsigned) windows_process.current_event.dwProcessId,
-	     (unsigned) GetLastError ());
-      detached = 0;
-    }
+    error (_("Can't detach process %u (error %u)"),
+	   (unsigned) windows_process.current_event.dwProcessId,
+	   (unsigned) GetLastError ());
   DebugSetProcessKillOnExit (FALSE);
 
-  if (detached)
-    target_announce_detach (from_tty);
+  target_announce_detach (from_tty);
 
   x86_cleanup_dregs ();
   switch_to_no_thread ();