From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date: Sat, 21 Oct 2023 18:10:23 +0000 (+0000)
Subject: add extra comments to sc-rfid test
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=eee2cb24e2f1185b2a47cb56e94c94d3d51efcdb;p=openpower-isa.git

add extra comments to sc-rfid test
---

diff --git a/src/openpower/test/trap/trap_cases.py b/src/openpower/test/trap/trap_cases.py
index 29dc07de..1e91eb8b 100644
--- a/src/openpower/test/trap/trap_cases.py
+++ b/src/openpower/test/trap/trap_cases.py
@@ -67,12 +67,13 @@ class TrapTestCase(TestAccumulatorBase):
                       expected=e)
 
     def case_1_sc_rfid(self):
+        # https://bugs.libre-soc.org/show_bug.cgi?id=982#c104
         lst = ["ba 3080" ]      # branch to 0xc08
         lst += ["addi 0,0,0"] * (0xbfc//4) # 0x004 to 0xbfc all NOP
-        lst += ["addi 3,0,3",  # 0xc00
+        lst += ["addi 3,0,3",  # 0xc00 set r3=3 as return result from sc
                 "rfid",        # 0xc04
-                "sc 0",        # 0xc08
-                "addi 0,0,2",  # 0xc0c
+                "sc 0",        # 0xc08 make syscall here
+                "addi 0,0,2",  # 0xc0c checks that we returned here
                 ]
         initial_regs = [0] * 32
         initial_regs[1] = 1