From: Jason Ekstrand Date: Sat, 17 Sep 2016 05:04:57 +0000 (-0700) Subject: nir/spirv/cfg: Detect switch_break after loop_break/continue X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ef3c5ac7fb915f489a553fa9d9a0c96d219545ad;p=mesa.git nir/spirv/cfg: Detect switch_break after loop_break/continue While the current CFG code is valid in the case where a switch break also happens to be a loop continue, it's a bit suboptimal. Since hardware is capable of handling the continue as a direct jump, it's better to use a continue instruction when we can than to bother with all of the nasty switch break lowering. Signed-off-by: Jason Ekstrand Cc: "12.0" --- diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index 475454e1d03..1c8c4f8e108 100644 --- a/src/compiler/spirv/vtn_cfg.c +++ b/src/compiler/spirv/vtn_cfg.c @@ -239,12 +239,12 @@ vtn_get_branch_type(struct vtn_block *block, swcase->fallthrough == block->switch_case); swcase->fallthrough = block->switch_case; return vtn_branch_type_switch_fallthrough; - } else if (block == switch_break) { - return vtn_branch_type_switch_break; } else if (block == loop_break) { return vtn_branch_type_loop_break; } else if (block == loop_cont) { return vtn_branch_type_loop_continue; + } else if (block == switch_break) { + return vtn_branch_type_switch_break; } else { return vtn_branch_type_none; }