From: Kenneth Graunke Date: Sun, 10 Aug 2014 23:15:51 +0000 (-0700) Subject: i965/fs: Don't set flag_subreg_nr = 1 on predicated FB write setup. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=efc818e3a4dae5634b6296412771c995c156228e;p=mesa.git i965/fs: Don't set flag_subreg_nr = 1 on predicated FB write setup. On Haswell, we implement "discard" via predicated SEND messages, using f0.1 instead of f0.0. To accomplish this, we set inst->flag_subreg to 1 on the FS_OPCODE_FB_WRITE. Most instructions using fs_inst::flag_subreg expand to a single assembly instruction. However, FS_OPCODE_FB_WRITE can generate several MOVs for setting up header information. We don't want to set flag_subreg on those, so override the default state back to 0. Signed-off-by: Kenneth Graunke Reviewed-by: Matt Turner Reviewed-by: Chris Forbes --- diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index d3509a0f1de..208b54f7fdd 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp @@ -154,6 +154,7 @@ fs_generator::generate_fb_write(fs_inst *inst) brw_set_default_mask_control(p, BRW_MASK_DISABLE); brw_set_default_predicate_control(p, BRW_PREDICATE_NONE); brw_set_default_compression_control(p, BRW_COMPRESSION_NONE); + brw_set_default_flag_reg(p, 0, 0); /* On HSW, the GPU will use the predicate on SENDC, unless the header is * present.