From: Simon Marchi <simon.marchi@efficios.com>
Date: Thu, 11 May 2023 17:33:51 +0000 (-0400)
Subject: gdb: remove unnecessary call to std::string constructor
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=efe2296bde30c22124ed31b70b7d860339927471;p=binutils-gdb.git

gdb: remove unnecessary call to std::string constructor

I spotted this explicit call to std::string, which creates an
unnecessary temporary extra std::string, while calling emplace_back.
I'm not sure if it has any impact in an optimized build, maybe the
compiler elides it.  But still, it's unnecessary.

Change-Id: I873337ea91db29ac06267aff8fc12dcf52824cac
Approved-By: Tom Tromey <tom@tromey.com>
---

diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c
index 948592a6f62..b84ce8375fb 100644
--- a/gdb/cli/cli-decode.c
+++ b/gdb/cli/cli-decode.c
@@ -155,7 +155,7 @@ cmd_list_element::command_components () const
   if (this->prefix != nullptr)
     result = this->prefix->command_components ();
 
-  result.emplace_back (std::string (this->name));
+  result.emplace_back (this->name);
   return result;
 }