From: Tom de Vries <tdevries@suse.de>
Date: Thu, 17 Aug 2023 08:21:18 +0000 (+0200)
Subject: [gdb/testsuite] Fix copy-to-remote in gdb.base/vfork-follow-parent.exp
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f0ae7030f00ea08c9ec09493b6ece447879bcab4;p=binutils-gdb.git

[gdb/testsuite] Fix copy-to-remote in gdb.base/vfork-follow-parent.exp

When running test-case gdb.base/vfork-follow-parent.exp, I run into:
...
ERROR: tcl error sourcing gdb/testsuite/gdb.base/vfork-follow-parent.exp.
ERROR: error copying "vforked-prog": no such file or directory
    while executing
"file copy -force $fromfile $tofile"
    (procedure "gdb_remote_download" line 29)
    invoked from within
"gdb_remote_download target $binfile3"
...

Fix this by:
- making the copy-to-remote conditional on is_remote target, and
- allowing gdb_remote_download to find $binfile3 by using
  standard_output_file.

Also remove unused variable remote_exec_prog.

Tested on x86_64-linux.
---

diff --git a/gdb/testsuite/gdb.base/vfork-follow-parent.exp b/gdb/testsuite/gdb.base/vfork-follow-parent.exp
index 70b54e729a5..a29706f58c5 100644
--- a/gdb/testsuite/gdb.base/vfork-follow-parent.exp
+++ b/gdb/testsuite/gdb.base/vfork-follow-parent.exp
@@ -30,7 +30,9 @@ if { [build_executable "compile $binfile3" $binfile3 $srcfile2] } {
     return -1
 }
 
-set remote_exec_prog [gdb_remote_download target $binfile3]
+if { [is_remote target] } {
+    gdb_remote_download target [standard_output_file $binfile3]
+}
 
 set opts [list debug additional_flags=-DTEST_EXIT]
 if { [build_executable "compile ${binfile}" ${binfile} ${srcfile} ${opts}] } {