From: Eric Engestrom Date: Tue, 8 May 2018 15:40:24 +0000 (+0100) Subject: meson: remove dependency antipattern X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f0cdc39b134dfc38f84b0f6dc1eaad86d28d4170;p=mesa.git meson: remove dependency antipattern `dep_valgrind != []` now (0.45) produces a warning that is quite explicit: WARNING: Trying to compare values of different types (DependencyHolder, list) using !=. The result of this is undefined and will become a hard error in a future Meson release. `dep_valgrind = []` used to be the recommended way to deal with non-existant dependency, but these don't work with `.found()`, so now the recommended way is to declare a impossible dependency, which null_dep does for us in Mesa. In short, we don't need and shouldn't check for `!= []` anywhere anymore. Reviewed-by: Dylan Baker Signed-off-by: Eric Engestrom --- diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index e6a3dc86753..09d44ddd687 100644 --- a/src/compiler/glsl/glcpp/meson.build +++ b/src/compiler/glsl/glcpp/meson.build @@ -57,7 +57,7 @@ glcpp = executable( if with_tests modes = ['unix', 'windows', 'oldmac', 'bizarro'] - if dep_valgrind != [] and dep_valgrind.found() + if dep_valgrind.found() modes += ['valgrind'] endif