From: Pedro Alves <palves@redhat.com>
Date: Wed, 26 Feb 2014 14:36:05 +0000 (+0000)
Subject: bsd-uthread.c: Don't install a to_xfer_partial method
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f2fce0ca3dd5e0dc37fabb75e8874c05e8bf5170;p=binutils-gdb.git

bsd-uthread.c: Don't install a to_xfer_partial method

Whatever the comment about deprecated_xfer_memory referred to,
deprecated_xfer_memory is gone now.  There's no need to install a
target method that just delegates, as that's what the default
delegator does already.

Tested by building an --enable-targets=all gdb on x86_64 Fedora 17.

gdb/
2014-02-26  Pedro Alves  <palves@redhat.com>

	* bsd-uthread.c (bsd_uthread_xfer_partial): Delete function.
	(bsd_uthread_target): Don't install bsd_uthread_xfer_partial as
	to_xfer_partial method.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 05d3e487e8d..1a7cc45ce67 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2014-02-26  Pedro Alves  <palves@redhat.com>
+
+	* bsd-uthread.c (bsd_uthread_xfer_partial): Delete function.
+	(bsd_uthread_target): Don't install bsd_uthread_xfer_partial as
+	to_xfer_partial method.
+
 2014-02-26  Pedro Alves  <palves@redhat.com>
 
 	* target.c (complete_target_initialization): Don't install
diff --git a/gdb/bsd-uthread.c b/gdb/bsd-uthread.c
index 39bc05a99ed..5f557639a86 100644
--- a/gdb/bsd-uthread.c
+++ b/gdb/bsd-uthread.c
@@ -331,21 +331,6 @@ bsd_uthread_store_registers (struct target_ops *ops,
     }
 }
 
-/* Implement the to_xfer_partial target_ops method.  FIXME: This
-   function is only there because otherwise GDB tries to invoke
-   deprecate_xfer_memory.  */
-
-static enum target_xfer_status
-bsd_uthread_xfer_partial (struct target_ops *ops, enum target_object object,
-			  const char *annex, gdb_byte *readbuf,
-			  const gdb_byte *writebuf,
-			  ULONGEST offset, ULONGEST len, ULONGEST *xfered_len)
-{
-  gdb_assert (ops->beneath->to_xfer_partial);
-  return ops->beneath->to_xfer_partial (ops->beneath, object, annex, readbuf,
-					writebuf, offset, len, xfered_len);
-}
-
 static ptid_t
 bsd_uthread_wait (struct target_ops *ops,
 		  ptid_t ptid, struct target_waitstatus *status, int options)
@@ -529,7 +514,6 @@ bsd_uthread_target (void)
   t->to_mourn_inferior = bsd_uthread_mourn_inferior;
   t->to_fetch_registers = bsd_uthread_fetch_registers;
   t->to_store_registers = bsd_uthread_store_registers;
-  t->to_xfer_partial = bsd_uthread_xfer_partial;
   t->to_wait = bsd_uthread_wait;
   t->to_resume = bsd_uthread_resume;
   t->to_thread_alive = bsd_uthread_thread_alive;