From: Richard Biener <rguenther@suse.de>
Date: Tue, 5 Nov 2019 11:00:24 +0000 (+0000)
Subject: re PR tree-optimization/92324 (ICE in expand_direct_optab_fn, at internal-fn.c:2890)
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f340142b839ca1ed576013b4dba3d34245bac7d0;p=gcc.git

re PR tree-optimization/92324 (ICE in expand_direct_optab_fn, at internal-fn.c:2890)

2019-11-05  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/92324
	* tree-vect-loop.c (check_reduction_path): For MIN/MAX require
	all signed or unsigned operations.

	* gcc.dg/vect/pr92324-3.c: New testcase.

From-SVN: r277822
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index cf4b36ff291..562b69d1aab 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2019-11-05  Richard Biener  <rguenther@suse.de>
+
+	PR tree-optimization/92324
+	* tree-vect-loop.c (check_reduction_path): For MIN/MAX require
+	all signed or unsigned operations.
+
 2019-11-05  Jan Hubicka  <jh@suse.cz>
 
 	* hsa-brig.c: Include alloc-pool.h
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 8a12ddc2c3a..1e372eb4a0f 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-05  Richard Biener  <rguenther@suse.de>
+
+	PR tree-optimization/92324
+	* gcc.dg/vect/pr92324-3.c: New testcase.
+
 2019-11-05  Jakub Jelinek  <jakub@redhat.com>
 
 	PR tree-optimization/91945
diff --git a/gcc/testsuite/gcc.dg/vect/pr92324-3.c b/gcc/testsuite/gcc.dg/vect/pr92324-3.c
new file mode 100644
index 00000000000..db5c399d4ff
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/vect/pr92324-3.c
@@ -0,0 +1,27 @@
+#include "tree-vect.h"
+
+int a[1024];
+unsigned b[1024];
+
+int __attribute__((noipa))
+foo (int n)
+{
+  int res = 0;
+  for (int i = 0; i < n; ++i)
+    {
+      res = res > a[i] ? res : a[i];
+      res = res > b[i] ? res : b[i];
+    }
+  return res;
+}
+
+int main ()
+{
+  check_vect ();
+  b[3] = (unsigned)__INT_MAX__ + 1;
+  if (foo (4) != -__INT_MAX__ - 1)
+    __builtin_abort ();
+  return 0;
+}
+
+/* { dg-final { scan-tree-dump-not "vectorized \[1-9\] loops" "vect" } } */
diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c
index 4064e9c0ff7..3448b55fa1b 100644
--- a/gcc/tree-vect-loop.c
+++ b/gcc/tree-vect-loop.c
@@ -2740,6 +2740,7 @@ pop:
   /* Check whether the reduction path detected is valid.  */
   bool fail = path.length () == 0;
   bool neg = false;
+  int sign = -1;
   *code = ERROR_MARK;
   for (unsigned i = 1; i < path.length (); ++i)
     {
@@ -2783,12 +2784,22 @@ pop:
 				    TREE_TYPE (gimple_assign_rhs1 (use_stmt))))
 	;
       else if (*code == ERROR_MARK)
-	*code = use_code;
+	{
+	  *code = use_code;
+	  sign = TYPE_SIGN (TREE_TYPE (gimple_assign_lhs (use_stmt)));
+	}
       else if (use_code != *code)
 	{
 	  fail = true;
 	  break;
 	}
+      else if ((use_code == MIN_EXPR
+		|| use_code == MAX_EXPR)
+	       && sign != TYPE_SIGN (TREE_TYPE (gimple_assign_lhs (use_stmt))))
+	{
+	  fail = true;
+	  break;
+	}
     }
   return ! fail && ! neg && *code != ERROR_MARK;
 }