From: Jakub Jelinek <jakub@redhat.com>
Date: Wed, 20 Jun 2018 16:07:21 +0000 (+0200)
Subject: re PR c++/86210 (Missing -Wnonnull warning for function defined in the same TU)
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f41b7612a9bbc18652f6577f79bf814a13d1510c;p=gcc.git

re PR c++/86210 (Missing -Wnonnull warning for function defined in the same TU)

	PR c++/86210
	* c-common.c (check_nonnull_arg): Use fold_for_warn.  Adjust obsolete
	comment.

	* g++.dg/warn/Wnonnull4.C: New test.

From-SVN: r261811
---

diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog
index 18388517e12..6b974daae27 100644
--- a/gcc/c-family/ChangeLog
+++ b/gcc/c-family/ChangeLog
@@ -1,3 +1,9 @@
+2018-06-20  Jakub Jelinek  <jakub@redhat.com>
+
+	PR c++/86210
+	* c-common.c (check_nonnull_arg): Use fold_for_warn.  Adjust obsolete
+	comment.
+
 2018-06-18  Martin Sebor  <msebor@redhat.com>
 
 	PR middle-end/85602
diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c
index 0e8efb53f40..f5e1111a772 100644
--- a/gcc/c-family/c-common.c
+++ b/gcc/c-family/c-common.c
@@ -5404,10 +5404,8 @@ check_nonnull_arg (void *ctx, tree param, unsigned HOST_WIDE_INT param_num)
   if (TREE_CODE (TREE_TYPE (param)) != POINTER_TYPE)
     return;
 
-  /* When not optimizing diagnose the simple cases of null arguments.
-     When optimization is enabled defer the checking until expansion
-     when more cases can be detected.  */
-  if (integer_zerop (param))
+  /* Diagnose the simple cases of null arguments.  */
+  if (integer_zerop (fold_for_warn (param)))
     {
       warning_at (pctx->loc, OPT_Wnonnull, "null argument where non-null "
 		  "required (argument %lu)", (unsigned long) param_num);
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 36305cb29fa..c30af52813f 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-06-20  Jakub Jelinek  <jakub@redhat.com>
+
+	PR c++/86210
+	* g++.dg/warn/Wnonnull4.C: New test.
+
 2018-06-20  Marek Polacek  <polacek@redhat.com>
 
 	PR c++/86240
diff --git a/gcc/testsuite/g++.dg/warn/Wnonnull4.C b/gcc/testsuite/g++.dg/warn/Wnonnull4.C
new file mode 100644
index 00000000000..d07a4452ddb
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/Wnonnull4.C
@@ -0,0 +1,21 @@
+// PR c++/86210
+// { dg-do compile }
+// { dg-options "-Wnonnull" }
+
+void *declared_not_defined (void *p) __attribute__((nonnull));
+
+inline void *declared_and_defined (void *p) __attribute__((nonnull));
+
+int
+main ()
+{
+  int *const p = 0;
+  declared_not_defined (p);	// { dg-warning "null argument where non-null required" }
+  declared_and_defined (p);	// { dg-warning "null argument where non-null required" }
+}
+
+void *
+declared_and_defined (void *p)
+{
+  return p;
+}