From: Tom Tromey <tom@tromey.com>
Date: Tue, 14 Feb 2023 07:28:47 +0000 (-0700)
Subject: Fix build bug in ppc-linux-nat.c
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f54cd6441de5c057b43ea1501c1b075984067e7c;p=binutils-gdb.git

Fix build bug in ppc-linux-nat.c

The buildbot pointed out that my value refactoring series introduced a
bug in ppc-linux-nat.c:

../../binutils-gdb/gdb/ppc-linux-nat.c: In member function ‘int ppc_linux_nat_target::num_memory_accesses(const std::vector<gdb::ref_ptr<value, value_ref_policy> >&)’:
../../binutils-gdb/gdb/ppc-linux-nat.c:2458:44: error: expected unqualified-id before ‘->’ token
 2458 |       if (VALUE_LVAL (v) == not_lval || v->->deprecated_modifiable () == 0)

I don't know how that happened, but I am checking in this patch which
I think should fix it.  It just removes the second "->".

I can't readily test this, so perhaps there's another bug lurking
after this one.
---

diff --git a/gdb/ppc-linux-nat.c b/gdb/ppc-linux-nat.c
index e4fcce694cf..32c0177228a 100644
--- a/gdb/ppc-linux-nat.c
+++ b/gdb/ppc-linux-nat.c
@@ -2455,7 +2455,7 @@ ppc_linux_nat_target::num_memory_accesses (const std::vector<value_ref_ptr>
       struct value *v = iter.get ();
 
       /* Constants and values from the history are fine.  */
-      if (v->lval () == not_lval || v->->deprecated_modifiable () == 0)
+      if (v->lval () == not_lval || v->deprecated_modifiable () == 0)
 	continue;
       else if (v->lval () == lval_memory)
 	{