From: Andrew Cagney <cagney@redhat.com>
Date: Tue, 28 Jul 1998 08:58:23 +0000 (+0000)
Subject: Add note about limitations of insn_field_cmp().
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f6b7bfcfa02171cfab029d89546ea3e0ee60c277;p=binutils-gdb.git

Add note about limitations of insn_field_cmp().
---

diff --git a/sim/igen/gen.c b/sim/igen/gen.c
index bd10f208084..5cc7e76ab90 100644
--- a/sim/igen/gen.c
+++ b/sim/igen/gen.c
@@ -355,12 +355,15 @@ insn_list_insert (insn_list **cur_insn_ptr,
       switch (duplicate_action)
 	{
 	case report_duplicate_insns:
-	  /* two instructions with the same constant field
-	     values across all words and bits */
+	  /* It would appear that we have two instructions with the
+	     same constant field values across all words and bits.
+	     This error can also occure when insn_field_cmp() is
+	     failing to differentiate between two instructions that
+	     differ only in their conditional fields. */
 	  warning (insn->line,
 		   "Two instructions with identical constant fields\n");
 	  error ((*cur_insn_ptr)->insn->line,
-		 "Location of second (duplicated?) instruction\n");
+		 "Location of duplicate instruction\n");
 	case merge_duplicate_insns:
 	  /* Add the opcode path to the instructions list */
 	  if (opcodes != NULL)