From: Kenneth Graunke Date: Tue, 25 Jul 2017 17:16:16 +0000 (-0700) Subject: i965: Fix offset addition in get_isl_surf. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f6e674fa5164a957e93e8dc1334a48c9e7ee7df9;p=mesa.git i965: Fix offset addition in get_isl_surf. Increase the value, not the pointer to the stack variable. Caught by Coverity (CID 1415574). Not shipped in a real release. Cc: "17.2" Reviewed-by: Topi Pohjolainen --- diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c index 250806d28e4..a0ca6ddf985 100644 --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c @@ -101,9 +101,9 @@ get_isl_surf(struct brw_context *brw, struct intel_mipmap_tree *mt, assert(view->levels == 1 && view->array_len == 1); assert(*tile_x == 0 && *tile_y == 0); - offset += intel_miptree_get_tile_offsets(mt, view->base_level, - view->base_array_layer, - tile_x, tile_y); + *offset += intel_miptree_get_tile_offsets(mt, view->base_level, + view->base_array_layer, + tile_x, tile_y); /* Minify the logical dimensions of the texture. */ const unsigned l = view->base_level - mt->first_level;