From: Marek Polacek <polacek@redhat.com>
Date: Thu, 8 May 2014 17:42:09 +0000 (+0000)
Subject: re PR c/61077 (_Atomic in the return type or argument types of main not diagnosed)
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f827930ae282f8ae4bedf0a38dbc2fa99d2b3d08;p=gcc.git

re PR c/61077 (_Atomic in the return type or argument types of main not diagnosed)

	PR c/61077
c-family/
	* c-common.c (check_main_parameter_types): Warn for _Atomic-qualified
	parameter type of main.
c/
	* c-decl.c (start_function): Warn for _Atomic-qualified return type
	of main.
testsuite/
	* gcc.dg/pr61077.c: New test.

From-SVN: r210229
---

diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog
index b7c65d35ff2..06a1b1468be 100644
--- a/gcc/c-family/ChangeLog
+++ b/gcc/c-family/ChangeLog
@@ -1,3 +1,9 @@
+2014-05-08  Marek Polacek  <polacek@redhat.com>
+
+	PR c/61077
+	* c-common.c (check_main_parameter_types): Warn for _Atomic-qualified
+	parameter type of main.
+
 2014-05-07  DJ Delorie  <dj@redhat.com>
 
 	* c-cppbuiltin.c (print_bits_of_hex): New.
diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c
index 0afe2f5ab38..33ad2508773 100644
--- a/gcc/c-family/c-common.c
+++ b/gcc/c-family/c-common.c
@@ -2193,6 +2193,20 @@ check_main_parameter_types (tree decl)
       if (type == void_type_node || type == error_mark_node )
 	break;
 
+      tree t = type;
+      if (TYPE_ATOMIC (t))
+	  pedwarn (input_location, OPT_Wmain,
+		   "%<_Atomic%>-qualified parameter type %qT of %q+D",
+		   type, decl);
+      while (POINTER_TYPE_P (t))
+	{
+	  t = TREE_TYPE (t);
+	  if (TYPE_ATOMIC (t))
+	    pedwarn (input_location, OPT_Wmain,
+		     "%<_Atomic%>-qualified parameter type %qT of %q+D",
+		     type, decl);
+	}
+
       ++argct;
       switch (argct)
 	{
diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog
index 379b8d74946..892537147d0 100644
--- a/gcc/c/ChangeLog
+++ b/gcc/c/ChangeLog
@@ -1,3 +1,9 @@
+2014-05-08  Marek Polacek  <polacek@redhat.com>
+
+	PR c/61077
+	* c-decl.c (start_function): Warn for _Atomic-qualified return type
+	of main.
+
 2014-05-06  Kenneth Zadeck  <zadeck@naturalbridge.com>
 	    Mike Stump  <mikestump@comcast.net>
 	    Richard Sandiford  <rdsandiford@googlemail.com>
diff --git a/gcc/c/c-decl.c b/gcc/c/c-decl.c
index 3abf6b98574..d8631fc3345 100644
--- a/gcc/c/c-decl.c
+++ b/gcc/c/c-decl.c
@@ -8045,6 +8045,9 @@ start_function (struct c_declspecs *declspecs, struct c_declarator *declarator,
       if (TYPE_MAIN_VARIANT (TREE_TYPE (TREE_TYPE (decl1)))
 	  != integer_type_node)
 	pedwarn (loc, OPT_Wmain, "return type of %qD is not %<int%>", decl1);
+      else if (TYPE_ATOMIC (TREE_TYPE (TREE_TYPE (decl1))))
+	pedwarn (loc, OPT_Wmain, "%<_Atomic%>-qualified return type of %qD",
+		 decl1);
 
       check_main_parameter_types (decl1);
 
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 7ea4d9ea91d..fe0683e511e 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2014-05-08  Marek Polacek  <polacek@redhat.com>
+
+	PR c/61077
+	* gcc.dg/pr61077.c: New test.
+
 2014-05-08  Tobias Burnus  <burnus@net-b.de>
 
 	* gfortran.dg/coarray_collectives_1.f90: New.
diff --git a/gcc/testsuite/gcc.dg/pr61077.c b/gcc/testsuite/gcc.dg/pr61077.c
new file mode 100644
index 00000000000..c0513f71f70
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr61077.c
@@ -0,0 +1,12 @@
+/* PR c/61077 */
+/* { dg-do compile } */
+/* { dg-options "-std=c11 -Wall" } */
+
+_Atomic int
+main (_Atomic int argc, _Atomic char **argv)
+/* { dg-warning "qualified return type" "return" { target *-*-* } 6 } */
+/* { dg-warning "qualified parameter type.*int" "parameter" { target *-*-* } 6 } */
+/* { dg-warning "qualified parameter type.*char" "parameter" { target *-*-* } 6 } */
+{
+  return 0;
+}