From: Mark Kettenis <kettenis@gnu.org>
Date: Fri, 12 Dec 2003 16:14:26 +0000 (+0000)
Subject: * observer.c (observer_test_first_observer)
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f82de61cdc85fcad122cc74fb761094ab7b480c8;p=binutils-gdb.git

* observer.c (observer_test_first_observer)
(observer_test_second_observer, observer_test_third_observer):
Don't define as `static'.
(observer_test_first_notification_function)
(observer_test_second_notification_function)
(observer_test_third_notification_function): Likewise.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5a940eec518..cf4fd34559b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2003-12-11  Mark Kettenis  <kettenis@gnu.org>
+
+	* observer.c (observer_test_first_observer)
+	(observer_test_second_observer, observer_test_third_observer):
+	Don't define as `static'.
+	(observer_test_first_notification_function)
+	(observer_test_second_notification_function)
+	(observer_test_third_notification_function): Likewise.
+
 2003-12-10  Mark Kettenis  <kettenis@gnu.org>
 
 	* solib.h (SOLIB_UNLOADED_LIBRARY_PATHNAME): Define as "" instead
diff --git a/gdb/observer.c b/gdb/observer.c
index 6815d0f9c83..fce5f9287d8 100644
--- a/gdb/observer.c
+++ b/gdb/observer.c
@@ -191,30 +191,30 @@ observer_notify_normal_stop (void)
   generic_observer_notify (normal_stop_subject, NULL);
 }
 
-/* The following code is only used to unit-test the observers from
-   our testsuite.  DO NOT USE IT within observer.c!  */
+/* The following code is only used to unit-test the observers from our
+   testsuite.  DO NOT USE IT within observer.c (or anywhere else for
+   that matter)!  */
 
-/* Since this code will not be used within GDB, it will trigger
-   a warning if we decide to compile with -Wunused-function.
-   This is ok for now.  (brobecker 2003-03-18)  */
+/* If we define these variables and functions as `static', the
+   compiler will optimize them out.  */
  
-static int observer_test_first_observer = 0;
-static int observer_test_second_observer = 0;
-static int observer_test_third_observer = 0;
+int observer_test_first_observer = 0;
+int observer_test_second_observer = 0;
+int observer_test_third_observer = 0;
 
-static void
+void
 observer_test_first_notification_function (void)
 {
   observer_test_first_observer++;
 }
 
-static void
+void
 observer_test_second_notification_function (void)
 {
   observer_test_second_observer++;
 }
 
-static void
+void
 observer_test_third_notification_function (void)
 {
   observer_test_third_observer++;